[Webkit-unassigned] [Bug 75553] [GTK][WK2] Initial FullScreen support

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=75553





--- Comment #45 from Carlos Garcia Campos <cgarcia at igalia.com>  2012-03-30 04:00:06 PST ---
(From update of attachment 134767)
View in context: https://bugs.webkit.org/attachment.cgi?id=134767&action=review

Looks great!

> Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:81
> +    bool fullScreenEnabled;

It seems this is only used inside #if ENABLE(FULLSCREEN_API) #endif blocks, so maybe we should add #if here?

> Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:614
> +
> +

extra line here?

> Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:616
> +

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.