[Webkit-unassigned] [Bug 82589] [EFL] LayoutTestController needs implementation of pageSizeAndMarginsInPixels

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=82589





--- Comment #5 from Raphael Kubo da Costa <rakuco at FreeBSD.org>  2012-03-29 18:28:58 PST ---
(In reply to comment #4)
> (From update of attachment 134540 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=134540&action=review
> 
> > Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp:150
> > +    String pageSizeAndMargins = DumpRenderTreeSupportEfl::pageSizeAndMarginsInPixels(browser->mainFrame(), pageNumber, width, height, marginTop, marginRight, marginBottom, marginLeft);
> 
> Should we use String class instead of char* in LTC ? I think we need to reduce util classes WebKit support. Because, the more we use WebKit class, the more we add visibility to eflsymbol.filter.

I'm favor of using String in DRTSupportEfl for now; besides making the code shorter and more C++-y, it's not clear yet that adding things to eflsymbol.filter is the best approach, and even if we later realize it is, we're mostly calling the same String constructor in all these methods being added, so it would amount to one line being added to the filter file.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.