[Webkit-unassigned] [Bug 82589] [EFL] LayoutTestController needs implementation of pageSizeAndMarginsInPixels

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=82589





--- Comment #4 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2012-03-29 18:04:54 PST ---
(From update of attachment 134540)
View in context: https://bugs.webkit.org/attachment.cgi?id=134540&action=review

> Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp:150
> +    String pageSizeAndMargins = DumpRenderTreeSupportEfl::pageSizeAndMarginsInPixels(browser->mainFrame(), pageNumber, width, height, marginTop, marginRight, marginBottom, marginLeft);

Should we use String class instead of char* in LTC ? I think we need to reduce util classes WebKit support. Because, the more we use WebKit class, the more we add visibility to eflsymbol.filter.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.