[Webkit-unassigned] [Bug 80123] [BlackBerry] Upstream LayerAnimation.{cpp, h}

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=80123





--- Comment #3 from Robin Cao <robin.cao at torchmobile.com.cn>  2012-03-27 19:13:35 PST ---
(In reply to comment #2)
> (From update of attachment 133971 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=133971&action=review
> 
> Looks good, but can still be improved a bit.
> 
> > Source/WebCore/platform/graphics/blackberry/LayerAnimation.cpp:112
> > +                                        ctf->y2(),
> 
> These params can be placed in the same line.
> 
Agree, looks better in the same line.

> > Source/WebCore/platform/graphics/blackberry/LayerAnimation.cpp:221
> > +        // A trick to avoid touching the refcount of shared TransformOperations on the wrong thread
> 
> Lacks period at end of sentence.
> 
Added.

> > Source/WebCore/platform/graphics/blackberry/LayerAnimation.h:24
> > +#include "GraphicsLayer.h"
> 
> Is this one needed?
> 
This is needed because LayerAnimation has a member variable: KeyframeValueList m_values;
And KeyframeValueList is defined in "GraphicsLayer.h".

> > Source/WebCore/platform/graphics/blackberry/LayerAnimation.h:50
> > +
> 
> Remove empty line.
> 
Fixed.

> > Source/WebCore/platform/graphics/blackberry/LayerAnimation.h:58
> > +        // This returns a copy of the animation.
> 
> This comment does not add much info.
Removed.

Thanks for the review.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.