[Webkit-unassigned] [Bug 80123] [BlackBerry] Upstream LayerAnimation.{cpp, h}

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=80123


Rob Buis <rwlbuis at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #133971|review?                     |review-
               Flag|                            |




--- Comment #2 from Rob Buis <rwlbuis at gmail.com>  2012-03-27 04:48:58 PST ---
(From update of attachment 133971)
View in context: https://bugs.webkit.org/attachment.cgi?id=133971&action=review

Looks good, but can still be improved a bit.

> Source/WebCore/platform/graphics/blackberry/LayerAnimation.cpp:112
> +                                        ctf->y2(),

These params can be placed in the same line.

> Source/WebCore/platform/graphics/blackberry/LayerAnimation.cpp:221
> +        // A trick to avoid touching the refcount of shared TransformOperations on the wrong thread

Lacks period at end of sentence.

> Source/WebCore/platform/graphics/blackberry/LayerAnimation.h:24
> +#include "GraphicsLayer.h"

Is this one needed?

> Source/WebCore/platform/graphics/blackberry/LayerAnimation.h:50
> +

Remove empty line.

> Source/WebCore/platform/graphics/blackberry/LayerAnimation.h:58
> +        // This returns a copy of the animation.

This comment does not add much info.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.