[Webkit-unassigned] [Bug 72841] NRWT: option --skip-pixel-test-if-no-baseline support on DRT

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=72841





--- Comment #17 from Dirk Pranke <dpranke at chromium.org>  2012-03-27 19:04:43 PST ---
The py(In reply to comment #16)
> Created an attachment (id=134036)
 --> (https://bugs.webkit.org/attachment.cgi?id=134036&action=review) [details]
> Patch
> 
> (In reply to comment #15)
> > just modify the driver implementations and delete the _pixel_tests member from them.
> 
> I have made the modifications that you suggested, and removed self._pixel_tests from DriverProxy. How should I modify the driver implementations?

You should be able to remove any references to self._pixel_tests in driver.py, chromium.py, and webkit.py as well. 

> And in your opinion what cause the fail in it:
> 
> FAIL: test_crash_log (webkitpy.layout_tests.port.chromium_unittest.ChromiumDriverTest)

I would bet this is unrelated. Does it still happen if you sync to the current tip of the tree?

The patch looks good to me otherwise, but I'd like someone else to sanity check the changes to TestController .. ossy or tony or adam, can you do that?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.