[Webkit-unassigned] [Bug 72841] NRWT: option --skip-pixel-test-if-no-baseline support on DRT

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=72841


Nandor Huszka <hnandor at inf.u-szeged.hu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #131828|0                           |1
        is obsolete|                            |




--- Comment #16 from Nandor Huszka <hnandor at inf.u-szeged.hu>  2012-03-27 05:21:46 PST ---
Created an attachment (id=134036)
 --> (https://bugs.webkit.org/attachment.cgi?id=134036&action=review)
Patch

(In reply to comment #15)
> just modify the driver implementations and delete the _pixel_tests member from them.

I have made the modifications that you suggested, and removed self._pixel_tests from DriverProxy. How should I modify the driver implementations? And in your opinion what cause the fail in it:

FAIL: test_crash_log (webkitpy.layout_tests.port.chromium_unittest.ChromiumDriverTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/hnandor/clean/Tools/Scripts/webkitpy/layout_tests/port/chromium_unittest.py", line 110, in test_crash_log
    self.assertEqual(driver_output.crash_log, 'mockcrashlog')
AssertionError: <webkitpy.thirdparty.mock.Mock object at 0x3a8ed50> != 'mockcrashlog'

Only this one unittest fails and it seems --skip-pixel-test-if-no-baseline option works good.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.