[Webkit-unassigned] [Bug 71207] An extra line break is inserted when pasting into a font element

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=71207


Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #134055|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #16 from Ryosuke Niwa <rniwa at webkit.org>  2012-03-27 10:39:03 PST ---
(From update of attachment 134055)
View in context: https://bugs.webkit.org/attachment.cgi?id=134055&action=review

> Source/WebCore/editing/ReplaceSelectionCommand.cpp:127
> +        if (pos.containerNode()->nonShadowBoundaryParentNode())
> +            nextPosition = positionInParentAfterNode(pos.containerNode());

Again, this is incorrect. You need to skip siblings of pos.containerNode() first.
I'd say that any solution that involves calling positionInParentAfterNode won't be correct.
On my second thought, we should be able to replace this enture function by pos.downstream().

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.