[Webkit-unassigned] [Bug 71207] An extra line break is inserted when pasting into a font element

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=71207





--- Comment #17 from yi shen <yi.4.shen at nokia.com>  2012-03-27 14:00:09 PST ---
Well, I think I misunderstood your comments #6 & #8. 

Regarding the pos.downstream(), I have tried it on my code and seems it doesn't work. Also, you can see it by checking Tony's comments (#10) in bug Bug 21840.

Now my question is why we need to skip the siblings of pos.containerNode()? Considering following case,

e.g.   <div><u>abc^</u>/n</div>

if we skip all the siblings, then the new insertion position is after the "/n", which seems incorrect for me.

(In reply to comment #16)
> (From update of attachment 134055 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=134055&action=review
> 
> > Source/WebCore/editing/ReplaceSelectionCommand.cpp:127
> > +        if (pos.containerNode()->nonShadowBoundaryParentNode())
> > +            nextPosition = positionInParentAfterNode(pos.containerNode());
> 
> Again, this is incorrect. You need to skip siblings of pos.containerNode() first.
> I'd say that any solution that involves calling positionInParentAfterNode won't be correct.
> On my second thought, we should be able to replace this enture function by pos.downstream().

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.