[Webkit-unassigned] [Bug 82333] [GTK] Use gtester -s to skip individual test cases instead of unit tests as a whole

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=82333





--- Comment #3 from Carlos Garcia Campos <cgarcia at igalia.com>  2012-03-27 07:57:53 PST ---
(In reply to comment #2)
> (From update of attachment 134050 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=134050&action=review
> 
> Looks good, but consider the small changes below before landing.
> 
> > Tools/Scripts/run-gtk-tests:34
> > +    class SkippedTest:
> > +
> > +        def __init__(self, test, reason, bug=None, test_cases=[]):
> > +            self.test = test
> 
> Might as well make this a top-level class. There's only one class in this file, but as time goes on we'll probably add more and want them to interact.

Ok.

> > Tools/Scripts/run-gtk-tests:261
> > +            for skipped in self._skipped_tests:
> > +                sys.stdout.write("%s" % skipped.test)
> > +                if skipped.test_cases:
> > +                    sys.stdout.write(" [%s]" % ", ".join(skipped.test_cases))
> > +                sys.stdout.write(": %s " % skipped.reason)
> > +                if skipped.bug is not None:
> > +                    sys.stdout.write("(https://bugs.webkit.org/show_bug.cgi?id=%d)" % skipped.bug)
> > +                sys.stdout.write("\n")
> 
> I think it'd make sense to have a SkippedTest.__str__ or SkippedTest.__repr__ that converted the class to a string. Then you would just do sys.stdout.write("%s" % skipped)

Makes a lot of sense, I'll do it

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.