[Webkit-unassigned] [Bug 82333] [GTK] Use gtester -s to skip individual test cases instead of unit tests as a whole
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Mar 27 07:33:26 PDT 2012
https://bugs.webkit.org/show_bug.cgi?id=82333
Martin Robinson <mrobinson at webkit.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #134050|review? |review+
Flag| |
--- Comment #2 from Martin Robinson <mrobinson at webkit.org> 2012-03-27 07:33:27 PST ---
(From update of attachment 134050)
View in context: https://bugs.webkit.org/attachment.cgi?id=134050&action=review
Looks good, but consider the small changes below before landing.
> Tools/Scripts/run-gtk-tests:34
> + class SkippedTest:
> +
> + def __init__(self, test, reason, bug=None, test_cases=[]):
> + self.test = test
Might as well make this a top-level class. There's only one class in this file, but as time goes on we'll probably add more and want them to interact.
> Tools/Scripts/run-gtk-tests:230
> + self._tests = [test for test in self._tests if self._should_run_test(test)]
You could write this as: self._tests = itertools.ifilterfalse(self._should_run_test, self._tests)
> Tools/Scripts/run-gtk-tests:248
> - names = [os.path.basename(test) for test in failed_tests]
> + names = [test.lstrip(self._programs_path) for test in failed_tests]
This seems unrelated -- there's a lot of general cleanup in this patch though.
> Tools/Scripts/run-gtk-tests:261
> + for skipped in self._skipped_tests:
> + sys.stdout.write("%s" % skipped.test)
> + if skipped.test_cases:
> + sys.stdout.write(" [%s]" % ", ".join(skipped.test_cases))
> + sys.stdout.write(": %s " % skipped.reason)
> + if skipped.bug is not None:
> + sys.stdout.write("(https://bugs.webkit.org/show_bug.cgi?id=%d)" % skipped.bug)
> + sys.stdout.write("\n")
I think it'd make sense to have a SkippedTest.__str__ or SkippedTest.__repr__ that converted the class to a string. Then you would just do sys.stdout.write("%s" % skipped)
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list