[Webkit-unassigned] [Bug 81121] [BlackBerry] Add WebPageCompositor class to BlackBerry WebKit API

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 23 17:22:06 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=81121





--- Comment #7 from Arvid Nilsson <anilsson at rim.com>  2012-03-23 17:22:06 PST ---
(In reply to comment #6)
> (From update of attachment 133587 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=133587&action=review
> 
> Looks good.
> 
> > Source/WebKit/blackberry/Api/WebPageCompositor.cpp:239
> > +WebPageCompositor::WebPageCompositor(WebPage* page, WebPageCompositorClient* client)
> 
> You could omit the param names, as you are not using them.
> 
> > Source/WebKit/blackberry/Api/WebPageCompositorClient.h:27
> > +class WebPage;
> 
> You are not using WebPage in this file.

D'oh, you already told me that the last time around =) Hang on, I can fix and put a new patch up.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list