[Webkit-unassigned] [Bug 81121] [BlackBerry] Add WebPageCompositor class to BlackBerry WebKit API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=81121


Rob Buis <rwlbuis at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #133587|review?                     |review+, commit-queue+
               Flag|                            |




--- Comment #6 from Rob Buis <rwlbuis at gmail.com>  2012-03-23 17:07:45 PST ---
(From update of attachment 133587)
View in context: https://bugs.webkit.org/attachment.cgi?id=133587&action=review

Looks good.

> Source/WebKit/blackberry/Api/WebPageCompositor.cpp:239
> +WebPageCompositor::WebPageCompositor(WebPage* page, WebPageCompositorClient* client)

You could omit the param names, as you are not using them.

> Source/WebKit/blackberry/Api/WebPageCompositorClient.h:27
> +class WebPage;

You are not using WebPage in this file.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.