[Webkit-unassigned] [Bug 81408] visual word movement: using cache to decrease the number of collectLeafBoxesInLogicalOrder on RootInlineBox

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=81408





--- Comment #6 from Xiaomei Ji <xji at chromium.org>  2012-03-21 14:47:24 PST ---
(From update of attachment 132616)
View in context: https://bugs.webkit.org/attachment.cgi?id=132616&action=review

>> Source/WebCore/editing/visible_units.cpp:160
>> +class CachedRootAndLeafBoxesInLogicalOrder {
> 
> It might be better to call it CachedLogicallyOrderedLeafBoxes since we're not exactly caching root inline boxes.
> We're caching leaf boxes under a particular root box.

done. And changed the local variable name from "rootAndLeafBoxes" to "leafBoxes".

>> Source/WebCore/editing/visible_units.cpp:167
>> +    size_t numOfBoxes() const { return m_leafBoxes.size(); }
> 
> Again, please don't use abbreviations like "num". Here, "size()" or "length()" would suffice since the class is called CachedRootAndLeafBoxesInLogicalOrder.

changed to "size()".

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.