[Webkit-unassigned] [Bug 81408] visual word movement: using cache to decrease the number of collectLeafBoxesInLogicalOrder on RootInlineBox

Wed Mar 21 11:50:07 PDT 2012

https://bugs.webkit.org/show_bug.cgi?id=81408

Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #132616|review?                     |review+
               Flag|                            |

--- Comment #5 from Ryosuke Niwa <rniwa at webkit.org>  2012-03-21 11:50:07 PST ---
(From update of attachment 132616)
View in context: https://bugs.webkit.org/attachment.cgi?id=132616&action=review

r=me provided numOfBoxes is renamed to something else.

> Source/WebCore/editing/visible_units.cpp:160
> +class CachedRootAndLeafBoxesInLogicalOrder {

It might be better to call it CachedLogicallyOrderedLeafBoxes since we're not exactly caching root inline boxes.
We're caching leaf boxes under a particular root box.

> Source/WebCore/editing/visible_units.cpp:167
> +    size_t numOfBoxes() const { return m_leafBoxes.size(); }

Again, please don't use abbreviations like "num". Here, "size()" or "length()" would suffice since the class is called CachedRootAndLeafBoxesInLogicalOrder.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.