[Webkit-unassigned] [Bug 81828] check-webkit-style (and the style bot) should complain about ChangeLogs without comments

Wed Mar 21 13:51:48 PDT 2012

https://bugs.webkit.org/show_bug.cgi?id=81828

--- Comment #10 from Maciej Stachowiak <mjs at apple.com>  2012-03-21 13:51:48 PST ---
(In reply to comment #7)
> > It already "nags" for missing bug URL, etc. Why is this not important enough to complain about?
> 
> I don't have statistics, but I don't believe that check fires very much.  We search and see whether folks who received that message were happy and changed their patch or whether they ignored it.  If they ignored the message, we should remove it.
> 
> > As long as the style bot is what forces us to fill out our TPS reports, it should make sure we do so correctly.
> 
> That's not the goal of the style bot.  The goal of the style bot is to save reviewers from pointing out obvious mistakes in a patch that a computer can flag.  That makes the project more efficient because reviewer time is a precious resource.

Based on your statement of the goal of the stylebot, it seems like the relevant standard for evaluating this change should be "will it save reviewers time in having to point out the mistake of insufficient ChangeLog" rather than "will contributors be happy when the script complains to them". And analogously for the bug URL requirement.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.