[Webkit-unassigned] [Bug 81828] check-webkit-style (and the style bot) should complain about ChangeLogs without comments

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=81828





--- Comment #9 from Brady Eidson <beidson at apple.com>  2012-03-21 13:47:14 PST ---
(In reply to comment #7)

> > As long as the style bot is what forces us to fill out our TPS reports, it should make sure we do so correctly.
> 
> That's not the goal of the style bot.  The goal of the style bot is to save reviewers from pointing out obvious mistakes in a patch that a computer can flag.  That makes the project more efficient because reviewer time is a precious resource.

Stating that stylebot has precisely one goal is a bit disingenuous.

Yes it's great that the stylebot automates part of the review process allowing reviewers to focus on more important things.

But another goal of the stylebot is that it enforces many parts of the review that reviewers have traditionally been too lax about enforcing.  If reviewers had actually been good about enforcing style guidelines the stylebot might never have came in to existence.

I think the point of this bug is that SOMETHING needs to enforce ChangeLogs are filled out properly.  Relying on reviewers obviously isn't working.

Since stylebot already enforces part of the ChangeLog responsibilities it made sense to suggest it enforce all of them.

Perhaps there should be an entirely separate tool that looks at just the ChangeLog and enforces both the brain dead part of filling out the ChangeLog in addition to the part that reviewers aren't doing a good enough job enforcing on their own.

I'm not sure what advantage there would be to making that a separate tool.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.