[Webkit-unassigned] [Bug 81558] Web Inspector: CodeGeneratorInspector.py: switch Runtime, Network and DOM domains to typed API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=81558





--- Comment #9 from Peter Rybin <prybin at chromium.org>  2012-03-21 13:36:14 PST ---
(From update of attachment 132670)
View in context: https://bugs.webkit.org/attachment.cgi?id=132670&action=review

>> Source/WebCore/inspector/CodeGeneratorInspector.py:2261
>> +
> 
> nit: 3 blank lines?

Done

>> Source/WebCore/inspector/InjectedScript.cpp:176
>> +        RefPtr<TypeBuilder::Runtime::RemoteObject> result = TypeBuilder::Runtime::RemoteObject::create()
> 
> Wrap should never through. We should return ErrorString in this case instead.

Done

>> Source/WebCore/inspector/InspectorDOMAgent.cpp:414
>> +        // FIXME: initialize root or error string param.
> 
> I am not sure I get the comment right. What you should do here is return ErrorString claiming that document is not available.

Done

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.