[Webkit-unassigned] [Bug 81558] Web Inspector: CodeGeneratorInspector.py: switch Runtime, Network and DOM domains to typed API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=81558


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #132670|review?                     |review-
               Flag|                            |




--- Comment #8 from Pavel Feldman <pfeldman at chromium.org>  2012-03-20 04:42:06 PST ---
(From update of attachment 132670)
View in context: https://bugs.webkit.org/attachment.cgi?id=132670&action=review

So why do the tests fail?

> Source/WebCore/inspector/CodeGeneratorInspector.py:2261
> +

nit: 3 blank lines?

> Source/WebCore/inspector/InjectedScript.cpp:176
> +        RefPtr<TypeBuilder::Runtime::RemoteObject> result = TypeBuilder::Runtime::RemoteObject::create()

Wrap should never through. We should return ErrorString in this case instead.

> Source/WebCore/inspector/InspectorDOMAgent.cpp:414
> +        // FIXME: initialize root or error string param.

I am not sure I get the comment right. What you should do here is return ErrorString claiming that document is not available.

> Source/WebCore/inspector/InspectorDOMAgent.cpp:1557
> +        // FIXME: make a proper default value or return error message.

return error.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.