[Webkit-unassigned] [Bug 71788] <area>-tag within <map> can get focus when it is hidden

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=71788





--- Comment #12 from Antaryami Pandia <antaryami.pandia at motorola.com>  2012-03-20 23:57:18 PST ---
(In reply to comment #11)
> No, that's not right. Elements with visibility:hidden have renderers. That's why Node::isFocusable() handles that case separately.

Thanks for the information.

> r- because of the visibility:hidden issue. You should also add test coverage for visibility:hidden.

will add visibility:hidden case.

> > Source/WebCore/html/HTMLAreaElement.cpp:203
> > +    HTMLImageElement* imageElem = imageElement();
> 
> We discourage abbreviations when naming variables. You could just call this 'image'.

oops.

> As I said before, this check won't handle the case where the image has 'visibility:hidden' set, but that case is already handled by Node's implementation of isFocusable(). I think you can just change these two lines to:
> 
>     return image->isFocusable();

will do.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.