[Webkit-unassigned] [Bug 71788] <area>-tag within <map> can get focus when it is hidden

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=71788


Andy Estes <aestes at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #132785|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #11 from Andy Estes <aestes at apple.com>  2012-03-20 11:36:34 PST ---
(From update of attachment 132785)
View in context: https://bugs.webkit.org/attachment.cgi?id=132785&action=review

r- because of the visibility:hidden issue. You should also add test coverage for visibility:hidden.

> Source/WebCore/html/HTMLAreaElement.cpp:203
> +    HTMLImageElement* imageElem = imageElement();

We discourage abbreviations when naming variables. You could just call this 'image'.

> Source/WebCore/html/HTMLAreaElement.cpp:205
> +    if (!(imageElem && imageElem->renderer()))
> +        return false;

As I said before, this check won't handle the case where the image has 'visibility:hidden' set, but that case is already handled by Node's implementation of isFocusable(). I think you can just change these two lines to:

    return image->isFocusable();

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.