[Webkit-unassigned] [Bug 80748] [EFL] Add PageClientEfl to WebCoreSupport

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=80748





--- Comment #8 from Hyowon Kim <hw1008.kim at samsung.com>  2012-03-18 03:06:09 PST ---
Thanks for your comments. :D

> > Source/WebKit/ChangeLog:8
> > +        No new tests. No behavior change.
> 
> Not really necessary here.

I've removed it. Done.

> > Source/WebKit/efl/WebCoreSupport/PageClientEfl.h:40
> > +    Evas_Object* view() { return m_view; }
> 
> Where is this being used?

To get Evas* in GraphicsContext3DPrivate::initialize()

bool GraphicsContext3DPrivate::initialize(GraphicsContext3D::Attributes attributes, HostWindow* hostWindow, bool renderDirectlyToHostWindow)
{
    PageClientEfl* pageClient = static_cast<PageClientEfl*>(hostWindow->platformPageClient());

    Evas* evas = evas_object_evas_get(pageClient->view());

    ......
}

> > Source/WebKit/efl/ewk/ewk_private.h:247
> > +bool ewk_view_accelerated_compositing_object_create(Evas_Object* ewkView, Evas_Native_Surface* nativeSurface, int x, int y, int width, int height);
> > +WebCore::GraphicsContext3D* ewk_view_accelerated_compositing_context_get(Evas_Object* ewkView);
> 
> These functions have no real implementation. Why don't you just call notImplemented() and return false/0 in PageClientEfl.cpp and get rid of these two functions here?

I just want to show what to do in PageClientEfl even though not implemented functions are called.
And I'll upload next patch for implementation of these two functions soon.

> > Source/WebKit/efl/ewk/ewk_private.h:250
> > +WebCore::PlatformPageClient ewk_view_page_client_get(Evas_Object* ewkView);
> 
> Please don't return a PlatformPageClient like this; follow the core{Frame,Page,HistoryItem} style instead.

Done.

> > Source/WebKit/efl/ewk/ewk_view.cpp:3931
> > +    EWK_VIEW_SD_GET_OR_RETURN(ewkView, smartData, false);
> > +    EWK_VIEW_PRIV_GET_OR_RETURN(smartData, priv, false);
> 
> You're always returning false, so these checks are not needed.
>
> > Source/WebKit/efl/ewk/ewk_view.cpp:3940
> > +    EWK_VIEW_SD_GET_OR_RETURN(ewkView, smartData, 0);
> > +    EWK_VIEW_PRIV_GET_OR_RETURN(smartData, priv, 0);
> 
> Ditto.

Done both~

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.