[Webkit-unassigned] [Bug 80748] [EFL] Add PageClientEfl to WebCoreSupport

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=80748





--- Comment #7 from Hyowon Kim <hw1008.kim at samsung.com>  2012-03-18 02:47:06 PST ---
Thanks for your comments. :D

> > Source/WebKit/efl/WebCoreSupport/PageClientEfl.cpp:38
> > +bool PageClientEfl::createEvasObjectForAcceleratedCompositing(Evas_Native_Surface *nativeSurface, int x, int y, int width, int height)
> 
> Minor nit : move '*' to data type.

Done.

> > Source/WebKit/efl/ewk/ewk_view.cpp:717
> > +    priv->pageClient = adoptPtr(new WebCore::PageClientEfl(smartData->self));
> 
> As you may know, there is PageClients struct of Page class in order to manage clients for WebCoreSupport. It looks confusion by this class name may occur.
> In my humble opinion,  it is better to use a little more clear name for PageClientEfl.

I agree with your opinion.
But, I have no idea of better name for this class now.
how about refactoring to rename it in another patch?

> > Source/WebKit/efl/ewk/ewk_view.cpp:3928
> > +bool ewk_view_accelerated_compositing_object_create(Evas_Object* ewkView, Evas_Native_Surface *nativeSurface, int x, int y, int width, int height)
> 
> ditto.

Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.