[Webkit-unassigned] [Bug 73638] [EFL] Implement 'registerProtocolHandler' function

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73638





--- Comment #5 from Dongwoo Joshua Im <dw.im at samsung.com>  2012-03-15 04:02:04 PST ---
(In reply to comment #4)
> (From update of attachment 131987 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=131987&action=review
> 
> > Source/WebKit/efl/ewk/ewk_custom_handlers.cpp:46
> > +bool ewk_custom_handlers_register_protocol_handler(Evas_Object* ewkView, const char* scheme, const char* baseUrl, const char* url, const char* title)
> 
> By the way, this file uses ewkView though this file is not ewk_view_xxx file. As you know, ewk files use only ewkView object in ewk_view files. I think we need to discuss how to process this structure. In my humble opinion, there are three methods.
> 
>  1. Fire a signal in ChromeClientEfl.
>      : Bug 73544 submitted a patch to send a signal in WebCoreSupport.

If it is ok, I prefer this way, as well.
Call a smart_callback in the ChromeClientEfl.cpp file.


>  2. Move only this function to ewk_view.cpp

5 more functions of Custom Handlers will be added.
I think ewk_view.cpp is too big already.


>  3. This file has an own structure, which has a view object dependency.

I think this is possible way also.
I can add the ewkView object into the structure, Ewk_Custom_Handlers_Data.


> 
> It seems to me 1 is most simple method for now.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.