[Webkit-unassigned] [Bug 81117] [GTK] Implement unicode submenu items

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=81117





--- Comment #5 from Carlos Garcia Campos <cgarcia at igalia.com>  2012-03-14 11:56:17 PST ---
(In reply to comment #4)
> (From update of attachment 131867 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=131867&action=review
> 
> >>> Source/WebCore/page/ContextMenuController.cpp:602
> >>> +    ContextMenuItem zwnj(ActionType, ContextMenuItemTagUnicodeInsertZWNJMark, contextMenuItemTagUnicodeInsertZWNJMark());
> >> 
> >> These names don't really follow WebKit coding conventions because they are abbreviations, but you could avoid them altogether if you do:
> >> 
> >> appendItem(ContextMenuItem(ActionType, ContextMenuItemTagUnicodeInsertLRMMark, contextMenuItemTagUnicodeInsertLRMMark()), &unicodeMenu);
> >> 
> >> etc.
> > 
> > That's not what all other methods of ContextMenuController file do, I prefer to keep consistency with the other method of the same file.
> 
> The older code may have been written before that part of the style guide,

really?

> so you should either do: 
> 
> appendItem(ContextMenuItem(ActionType, ContextMenuItemTagUnicodeInsertLRMMark, contextMenuItemTagUnicodeInsertLRMMark()), &unicodeMenu);

I would have to try, but I think that won't work, appendItem expects a ContextMenuItem&, and I guess that's the reason while all other methods use a variable to create context menu items.

> or
> 
> ContextMenuItem leftToRightMarkItem(ActionType, ContextMenuItemTagUnicodeInsertLRMMark, contextMenuItemTagUnicodeInsertLRMMark());
> appendItem(leftToRightMarkItem &unicodeMenu);

Ok, I'll rename the variables.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.