[Webkit-unassigned] [Bug 81117] [GTK] Implement unicode submenu items

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=81117





--- Comment #4 from Martin Robinson <mrobinson at webkit.org>  2012-03-14 11:24:48 PST ---
(From update of attachment 131867)
View in context: https://bugs.webkit.org/attachment.cgi?id=131867&action=review

>>> Source/WebCore/page/ContextMenuController.cpp:602
>>> +    ContextMenuItem zwnj(ActionType, ContextMenuItemTagUnicodeInsertZWNJMark, contextMenuItemTagUnicodeInsertZWNJMark());
>> 
>> These names don't really follow WebKit coding conventions because they are abbreviations, but you could avoid them altogether if you do:
>> 
>> appendItem(ContextMenuItem(ActionType, ContextMenuItemTagUnicodeInsertLRMMark, contextMenuItemTagUnicodeInsertLRMMark()), &unicodeMenu);
>> 
>> etc.
> 
> That's not what all other methods of ContextMenuController file do, I prefer to keep consistency with the other method of the same file.

The older code may have been written before that part of the style guide, so you should either do: 

appendItem(ContextMenuItem(ActionType, ContextMenuItemTagUnicodeInsertLRMMark, contextMenuItemTagUnicodeInsertLRMMark()), &unicodeMenu);

or

ContextMenuItem leftToRightMarkItem(ActionType, ContextMenuItemTagUnicodeInsertLRMMark, contextMenuItemTagUnicodeInsertLRMMark());
appendItem(leftToRightMarkItem &unicodeMenu);

New code should follow the style guide.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.