[Webkit-unassigned] [Bug 80748] [EFL] Add PageClientEfl to WebCoreSupport

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=80748





--- Comment #3 from Raphael Kubo da Costa <kubo at profusion.mobi>  2012-03-14 06:23:37 PST ---
(From update of attachment 131780)
View in context: https://bugs.webkit.org/attachment.cgi?id=131780&action=review

> Source/WebKit/ChangeLog:8
> +        No new tests. No behavior change.

Not really necessary here.

> Source/WebKit/efl/WebCoreSupport/PageClientEfl.h:40
> +    Evas_Object* view() { return m_view; }

Where is this being used?

> Source/WebKit/efl/ewk/ewk_private.h:247
> +bool ewk_view_accelerated_compositing_object_create(Evas_Object* ewkView, Evas_Native_Surface* nativeSurface, int x, int y, int width, int height);
> +WebCore::GraphicsContext3D* ewk_view_accelerated_compositing_context_get(Evas_Object* ewkView);

These functions have no real implementation. Why don't you just call notImplemented() and return false/0 in PageClientEfl.cpp and get rid of these two functions here?

> Source/WebKit/efl/ewk/ewk_private.h:250
> +WebCore::PlatformPageClient ewk_view_page_client_get(Evas_Object* ewkView);

Please don't return a PlatformPageClient like this; follow the core{Frame,Page,HistoryItem} style instead.

> Source/WebKit/efl/ewk/ewk_view.cpp:3931
> +    EWK_VIEW_SD_GET_OR_RETURN(ewkView, smartData, false);
> +    EWK_VIEW_PRIV_GET_OR_RETURN(smartData, priv, false);

You're always returning false, so these checks are not needed.

> Source/WebKit/efl/ewk/ewk_view.cpp:3940
> +    EWK_VIEW_SD_GET_OR_RETURN(ewkView, smartData, 0);
> +    EWK_VIEW_PRIV_GET_OR_RETURN(smartData, priv, 0);

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.