[Webkit-unassigned] [Bug 80748] [EFL] Add PageClientEfl to WebCoreSupport

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=80748





--- Comment #2 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2012-03-13 22:18:52 PST ---
(From update of attachment 131780)
View in context: https://bugs.webkit.org/attachment.cgi?id=131780&action=review

> Source/WebKit/efl/WebCoreSupport/PageClientEfl.cpp:38
> +bool PageClientEfl::createEvasObjectForAcceleratedCompositing(Evas_Native_Surface *nativeSurface, int x, int y, int width, int height)

Minor nit : move '*' to data type.

> Source/WebKit/efl/ewk/ewk_view.cpp:717
> +    priv->pageClient = adoptPtr(new WebCore::PageClientEfl(smartData->self));

As you may know, there is PageClients struct of Page class in order to manage clients for WebCoreSupport. It looks confusion by this class name may occur.
In my humble opinion,  it is better to use a little more clear name for PageClientEfl.

> Source/WebKit/efl/ewk/ewk_view.cpp:3928
> +bool ewk_view_accelerated_compositing_object_create(Evas_Object* ewkView, Evas_Native_Surface *nativeSurface, int x, int y, int width, int height)

ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.