[Webkit-unassigned] [Bug 80789] Web Inspector: TypeBuilder: Introduce OptOutput class for optional output parameters
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Mar 12 11:08:13 PDT 2012
https://bugs.webkit.org/show_bug.cgi?id=80789
--- Comment #4 from Peter Rybin <prybin at chromium.org> 2012-03-12 11:08:13 PST ---
> > Source/WebCore/inspector/CodeGeneratorInspector.py:2244
> > +class OptOutput {
> Please make this class non-copyable to avoid passing it by value.
Done
> > Source/WebCore/inspector/InspectorDOMDebuggerAgent.cpp:67
> > +static const InspectorFrontend::Debugger::Reason::Enum domNativeBreakpointType = InspectorFrontend::Debugger::Reason::DOM;
> Is there a reason for not inlining the new constant values?
Done
> > Source/WebCore/inspector/InspectorPageAgent.cpp:508
> > + *cookiesString = "";
>
> The protocol description says it should contain result of document.cookies even if the cookies array is present. Please file a bug on this and put FIXME here.
Done
> > Source/WebCore/inspector/InspectorPageAgent.cpp:839
> > + frameObject->setSecurityOrigin(frame->document()->securityOrigin()->toString());
>
> Should this parameter be required if it is always present anyway? The type is still hidden anyway so I think we may want to fix this.
Done
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list