[Webkit-unassigned] [Bug 80789] Web Inspector: TypeBuilder: Introduce OptOutput class for optional output parameters
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Mar 12 03:00:54 PDT 2012
https://bugs.webkit.org/show_bug.cgi?id=80789
Yury Semikhatsky <yurys at chromium.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #131257|review? |review+
Flag| |
--- Comment #3 from Yury Semikhatsky <yurys at chromium.org> 2012-03-12 03:00:53 PST ---
(From update of attachment 131257)
View in context: https://bugs.webkit.org/attachment.cgi?id=131257&action=review
> Source/WebCore/inspector/CodeGeneratorInspector.py:2244
> +class OptOutput {
Please make this class non-copyable to avoid passing it by value.
> Source/WebCore/inspector/InspectorDOMDebuggerAgent.cpp:67
> +static const InspectorFrontend::Debugger::Reason::Enum domNativeBreakpointType = InspectorFrontend::Debugger::Reason::DOM;
Is there a reason for not inlining the new constant values?
> Source/WebCore/inspector/InspectorPageAgent.cpp:508
> + *cookiesString = "";
The protocol description says it should contain result of document.cookies even if the cookies array is present. Please file a bug on this and put FIXME here.
> Source/WebCore/inspector/InspectorPageAgent.cpp:839
> + frameObject->setSecurityOrigin(frame->document()->securityOrigin()->toString());
Should this parameter be required if it is always present anyway? The type is still hidden anyway so I think we may want to fix this.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list