[Webkit-unassigned] [Bug 80760] WinLauncher should show loading errors

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=80760


Adam Roben (:aroben) <aroben at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #131250|review?                     |review-
               Flag|                            |




--- Comment #20 from Adam Roben (:aroben) <aroben at webkit.org>  2012-03-12 11:03:08 PST ---
(From update of attachment 131250)
View in context: https://bugs.webkit.org/attachment.cgi?id=131250&action=review

> Tools/WinLauncher/WinLauncher.cpp:152
> +    ::MessageBoxW(0, static_cast<LPCWSTR>(errorDescription), L"Error", MB_APPLMODAL | MB_OK);

Using a message box seems awfully heavy-handed. Is there some less disruptive way of notifying the user?

> Tools/WinLauncher/WinLauncher.h:53
>      virtual HRESULT STDMETHODCALLTYPE didFailProvisionalLoadWithError( 
>          /* [in] */ IWebView *webView,
>          /* [in] */ IWebError *error,
> -        /* [in] */ IWebFrame *frame) { return S_OK; }
> +        /* [in] */ IWebFrame *frame) { return didFailProvisionalLoadWithError(webView, error); }

I don't think the extra overload of didFailProvisionalLoadWithError is needed. I'd just move the implementation of this overload to the .cpp file and put the MessageBox code there.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.