[Webkit-unassigned] [Bug 80760] WinLauncher should show loading errors

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=80760





--- Comment #21 from Ashod Nakashian <ashodnakashian at yahoo.com>  2012-03-12 12:19:28 PST ---
(In reply to comment #20)
> (From update of attachment 131250 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=131250&action=review
> 
> > Tools/WinLauncher/WinLauncher.cpp:152
> > +    ::MessageBoxW(0, static_cast<LPCWSTR>(errorDescription), L"Error", MB_APPLMODAL | MB_OK);
> 
> Using a message box seems awfully heavy-handed. Is there some less disruptive way of notifying the user?

Well, as it stands page load errors don't even bother to notify the user at all. So between silent failure and a message box, I think the latter is a more welcome response (I know because I scratched my head until I figured that loading was failing - especially that during loading there is no indication of loading progress.)

Now regarding alternatives I'm thinking a status bar would be good to have. But until we add a status bar (or some other notification method,) considering that page load failures are dead-ends, I find message boxes to be simple and very informative. Notice also that this is a test/demo project, it's not supposed to be elegant (not that it's a bad thing, but complexity defeats both goals).

> 
> > Tools/WinLauncher/WinLauncher.h:53
> >      virtual HRESULT STDMETHODCALLTYPE didFailProvisionalLoadWithError( 
> >          /* [in] */ IWebView *webView,
> >          /* [in] */ IWebError *error,
> > -        /* [in] */ IWebFrame *frame) { return S_OK; }
> > +        /* [in] */ IWebFrame *frame) { return didFailProvisionalLoadWithError(webView, error); }
> 
> I don't think the extra overload of didFailProvisionalLoadWithError is needed. I'd just move the implementation of this overload to the .cpp file and put the MessageBox code there.

That sounds reasonable. However I didn't want to change existing code/conventions. I tend to be conservative and conformist when contributing to existing code. If there are no objections to my response of the previous issue, I suggest improving this (and the other similar cases) in a separate patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.