[Webkit-unassigned] [Bug 80760] WinLauncher should show loading errors

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=80760





--- Comment #16 from Ashod Nakashian <ashodnakashian at yahoo.com>  2012-03-11 10:58:43 PST ---
(In reply to comment #15)
> (From update of attachment 131244 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=131244&action=review
> 
> > Tools/WinLauncher/WinLauncher.cpp:149
> > +    if (FAILED(hr))
> 
> is returning S_OK in this case "correct"?

Yes it is, as the handler didn't fail, just an internal operation that doesn't affect the correctness of the handler itself (this may be more complicated in other cases, but in this case we're simply handling the page load failure to inform the user, not to take any further action that is subject to success or failure.)

> 
> > Tools/WinLauncher/WinLauncher.cpp:152
> > +        ::MessageBoxW(0, (LPCWSTR)errorDescription, L"Error", MB_APPLMODAL | MB_OK);
> 
> please use static_cast
> 
> also can you merge the redundant code? here is it possible to do sth like if(FAILED) errorDescription = ""; MessageBoxW(.., errorDescription, ...)

Both done. Updating patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.