[Webkit-unassigned] [Bug 80760] WinLauncher should show loading errors

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=80760





--- Comment #15 from Patrick R. Gansterer <paroga at paroga.com>  2012-03-11 10:43:41 PST ---
(From update of attachment 131244)
View in context: https://bugs.webkit.org/attachment.cgi?id=131244&action=review

> Tools/WinLauncher/WinLauncher.cpp:149
> +    if (FAILED(hr))

is returning S_OK in this case "correct"?

> Tools/WinLauncher/WinLauncher.cpp:152
> +        ::MessageBoxW(0, (LPCWSTR)errorDescription, L"Error", MB_APPLMODAL | MB_OK);

please use static_cast

also can you merge the redundant code? here is it possible to do sth like if(FAILED) errorDescription = ""; MessageBoxW(.., errorDescription, ...)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.