[Webkit-unassigned] [Bug 80519] [BlackBerry] Set ResourceRequest TargetType in WebPagePrivate::load()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=80519





--- Comment #16 from jochen at chromium.org  2012-03-08 05:24:14 PST ---
(In reply to comment #15)
> (In reply to comment #14)
> > Wouldn't this code then be needed for PLATFORM(CHROMIUM) as well?  I've added jochen to the CC list since he understands TargetType better than I do.
> 
> Yes, I think logically CHROMIUM need this code as well to make the TargetType always correct, but I am not sure how ResourceRequest::TargetType is used in Chromium, so not sure whether Chromium needs it here in real world.
> 
> But the way Chromium does it, setting TargetType in FrameLoaderClient::dispatchWillSendRequest(), leaves a gap when the target type has a default value, and in this gap, FrameLoadClient::dispatchDecidePolicyForXXX() is called, if the FrameLoaderClient decides to check TargetType in these methods, there will be a problem.

In the chromium port, the target type is not set correctly in lots of different places. However, I think the correct solution to this problem is to move TargetType out of ResourceRequest, and have all calls that pass a ResourceRequest around in loader/ also take a TargetType parameter.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.