[Webkit-unassigned] [Bug 80519] [BlackBerry] Set ResourceRequest TargetType in WebPagePrivate::load()

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 7 19:00:31 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=80519





--- Comment #15 from Lyon Chen <liachen at rim.com>  2012-03-07 19:00:31 PST ---
(In reply to comment #14)
> Wouldn't this code then be needed for PLATFORM(CHROMIUM) as well?  I've added jochen to the CC list since he understands TargetType better than I do.

Yes, I think logically CHROMIUM need this code as well to make the TargetType always correct, but I am not sure how ResourceRequest::TargetType is used in Chromium, so not sure whether Chromium needs it here in real world.

But the way Chromium does it, setting TargetType in FrameLoaderClient::dispatchWillSendRequest(), leaves a gap when the target type has a default value, and in this gap, FrameLoadClient::dispatchDecidePolicyForXXX() is called, if the FrameLoaderClient decides to check TargetType in these methods, there will be a problem.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list