[Webkit-unassigned] [Bug 79867] [BlackBerry] Upstream GraphicsLayerBlackBerry.{h, cpp}

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=79867





--- Comment #9 from Robin Cao <robin.cao at torchmobile.com.cn>  2012-03-07 23:51:23 PST ---
(In reply to comment #8)
> (From update of attachment 130582 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=130582&action=review
> 
> Almost there, have a look especially at the release issue. Maybe you can get Leo to cq+ for you once fixed.
> 
> > Source/WebCore/platform/graphics/blackberry/GraphicsLayerBlackBerry.cpp:146
> > +    if (GraphicsLayer::replaceChild(oldChild, newChild)) {
> 
> I think early return may look better here.
> 
Fixed.

> > Source/WebCore/platform/graphics/blackberry/GraphicsLayerBlackBerry.cpp:384
> > +            return layerAnimation.release();
> 
> I dont think you want to release here? Note that removeAnimationByIdAndProperty doesn't do it either.

"return layerAnimation.release();" is equivalent to "return layerAnimation;" in functionality. But for readability and consistency it makes sense to use "return layerAnimation;" in both functions.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.