[Webkit-unassigned] [Bug 79867] [BlackBerry] Upstream GraphicsLayerBlackBerry.{h, cpp}

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=79867


Rob Buis <rwlbuis at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #130582|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #8 from Rob Buis <rwlbuis at gmail.com>  2012-03-07 11:30:12 PST ---
(From update of attachment 130582)
View in context: https://bugs.webkit.org/attachment.cgi?id=130582&action=review

Almost there, have a look especially at the release issue. Maybe you can get Leo to cq+ for you once fixed.

> Source/WebCore/platform/graphics/blackberry/GraphicsLayerBlackBerry.cpp:146
> +    if (GraphicsLayer::replaceChild(oldChild, newChild)) {

I think early return may look better here.

> Source/WebCore/platform/graphics/blackberry/GraphicsLayerBlackBerry.cpp:384
> +            return layerAnimation.release();

I dont think you want to release here? Note that removeAnimationByIdAndProperty doesnt do it either.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.