[Webkit-unassigned] [Bug 80519] [BlackBerry] Set ResourceRequest TargetType in WebPagePrivate::load()

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 7 12:23:37 PST 2012


--- Comment #5 from Lyon Chen <liachen at rim.com>  2012-03-07 12:23:37 PST ---
(In reply to comment #3)

> Is there any way we can set this somewhere other than FrameLoader, preferably somewhere that doesn't require an #if PLATFORM()? chromium, e.g., does this in its FrameLoaderClientImpl::dispatchWillSendRequest().

The problem is FrameLoaderClientImpl::dispatchWillSendRequest() is too late a place to set target type. FrameLoaderClient::dispatchDecidePolicyForNavigationAction() could check the target type too, and it is called before dispatchWillSendRequest().

We can avoid check target type in dispatchDecidePolicyForNavigationAction(), or any other places before dispatchWillSendRequest() is called, but it will create a implicit situation that you need to know when the target type is set, not just assuming it is always right.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list