[Webkit-unassigned] [Bug 80519] [BlackBerry] Set ResourceRequest TargetType in WebPagePrivate::load()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=80519


Joe Mason <jmason at rim.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jmason at rim.com




--- Comment #4 from Joe Mason <jmason at rim.com>  2012-03-07 12:00:53 PST ---
(In reply to comment #3)
> Is there any way we can set this somewhere other than FrameLoader, preferably somewhere that doesn't require an #if PLATFORM()? chromium, e.g., does this in its FrameLoaderClientImpl::dispatchWillSendRequest().

We do this too right now.  This patch should remove the existing code from dispatchWillSendRequest as well as adding it to FrameLoader.  (If we decide it's a good idea at all.)

The problem is then we have to be very careful not to check the targetType before it's actually set, such as from dispatchDecidePolicyForResponse.  Which can be done, but arranging things so we don't have to be that vigilant is good defensive programming.

I'm not happy with the ifdef myself - we should make another try to find a better solution.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.