[Webkit-unassigned] [Bug 80027] [chromium] Increase size of Combo Box Options for touch and high DPI devices

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=80027





--- Comment #4 from Tim Dresser <tdresser at chromium.org>  2012-03-07 06:39:11 PST ---
(In reply to comment #2)
> (From update of attachment 129710 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=129710&action=review
> 
> > Source/WebCore/platform/chromium/PopupListBox.cpp:49
> > +#include "Settings.h"
> 
> do you really need this include?
> 

Nope, removed.

> > Source/WebCore/platform/chromium/PopupListBox.cpp:357
> > +    const int& scale = m_settings.defaultDeviceScaleFactor;
> 
> why make this a reference?  it seems like making a copy of the int should be sufficient unless you really need the indirection.
> 

Done.

> > Source/WebCore/platform/chromium/PopupListBox.cpp:397
> > +    const int& scale = m_settings.defaultDeviceScaleFactor;
> 
> ditto
> 
> > Source/WebCore/platform/chromium/PopupListBox.cpp:401
> > +        // Height and y will both be evenly divisible by scale.
> 
> should you perhaps assert this?  it seems like rounding errors if possible would be annoying.
> 

Done.

> > Source/WebCore/platform/chromium/PopupListBox.cpp:632
> > +    const int& scale = m_settings.defaultDeviceScaleFactor;
> 
> ditto
> 
> > Source/WebCore/platform/chromium/PopupListBox.cpp:634
> > +    if (WebCore::RuntimeEnabledFeatures::touchEnabled())
> 
> you should not need the "WebCore::" prefix
> 

Done.

> > Source/WebCore/rendering/RenderMenuList.cpp:312
> > +    const int& scale = document()->page()->settings()->defaultDeviceScaleFactor();
> 
> no reference
> 
> > Source/WebKit/chromium/src/WebViewImpl.cpp:637
> > +        // That tap triggered a select popup which is the same as the one that
> 
> so we will see a flickering of the select popup?  is there some way to mitigate / avoid that?

This code is parallel to Source/WebCore/rendering/RenderMenuList.cpp:516. The popup is never shown, as it is hidden before a render occurs.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.