[Webkit-unassigned] [Bug 80027] [chromium] Increase size of Combo Box Options for touch and high DPI devices

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 9 11:49:09 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=80027


Darin Fisher (:fishd, Google) <fishd at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #130614|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #5 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2012-03-09 11:49:09 PST ---
(From update of attachment 130614)
View in context: https://bugs.webkit.org/attachment.cgi?id=130614&action=review

Switch the 'const int scale' to just 'int scale', and then R=me

> Source/WebCore/platform/chromium/PopupListBox.cpp:356
> +    const int scale = m_settings.defaultDeviceScaleFactor;

nit: no need for 'const' in front of int here.  it is unnecessary verbosity.
we usually only write 'const int' when giving a name to an int literal.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list