[Webkit-unassigned] [Bug 80121] [BlackBerry] Upstream Texture and TextureCache

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=80121





--- Comment #6 from Robin Cao <robin.cao at torchmobile.com.cn>  2012-03-06 22:22:38 PST ---
(In reply to comment #5)
> (From update of attachment 130084 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=130084&action=review
> 
> > Source/WebCore/platform/graphics/blackberry/Texture.cpp:83
> > +    bool subImage = (tile.size() == m_size);
> 
> Could just be bool subImage = tile.size() == m_size;
> 
> > Source/WebCore/platform/graphics/blackberry/Texture.cpp:91
> > +    IntSize yeOldeSize = size;
> 
> yeOldeSize sounds a bit silly, can just be oldSize.
> 
> > Source/WebCore/platform/graphics/blackberry/Texture.h:24
> > +#include "IntRect.h"
> 
> Looks like it can be a forward class reference.
> 
> > Source/WebCore/platform/graphics/blackberry/TextureCacheCompositingThread.h:29
> > +#include <memory>
> 
> Nothing in that file seems needed here?

Thank you very much! Will fix these before landing.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.