[Webkit-unassigned] [Bug 80121] [BlackBerry] Upstream Texture and TextureCache

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 5 06:55:22 PST 2012


Rob Buis <rwlbuis at gmail.com> changed:

           What    |Removed                     |Added
 Attachment #130084|review?                     |review+
               Flag|                            |

--- Comment #5 from Rob Buis <rwlbuis at gmail.com>  2012-03-05 06:55:22 PST ---
(From update of attachment 130084)
View in context: https://bugs.webkit.org/attachment.cgi?id=130084&action=review

Looks good, please have a look at my remarks before landing, maybe Leo can set cq+ once that is done.

> Source/WebCore/platform/graphics/blackberry/Texture.cpp:83
> +    bool subImage = (tile.size() == m_size);

Could just be bool subImage = tile.size() == m_size;

> Source/WebCore/platform/graphics/blackberry/Texture.cpp:91
> +    IntSize yeOldeSize = size;

yeOldeSize sounds a bit silly, can just be oldSize.

> Source/WebCore/platform/graphics/blackberry/Texture.h:24
> +#include "IntRect.h"

Looks like it can be a forward class reference.

> Source/WebCore/platform/graphics/blackberry/TextureCacheCompositingThread.h:29
> +#include <memory>

Nothing in that file seems needed here?

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list