[Webkit-unassigned] [Bug 78575] Web Inspector: Disable dock button when not allowed to dock

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 6 11:33:31 PST 2012


--- Comment #27 from Joseph Pecoraro <joepeck at webkit.org>  2012-03-06 11:33:31 PST ---
(In reply to comment #26)
> (From update of attachment 130308 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=130308&action=review
> One small comment, otherwise looks good. Thanks for following up.
> > Source/WebCore/inspector/InspectorFrontendClient.h:69
> > +    virtual void setDockingUnavailable(bool) { }
> I think all the ports that are going to call this methods inherit from InspectorFrontendClientLocal,
> so you actually don't need it here. It also does not have to be virtual, it is just a helper function.

Done. Thanks for the extra comments. The patch feels better.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list