[Webkit-unassigned] [Bug 78575] Web Inspector: Disable dock button when not allowed to dock

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=78575


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #130308|review?                     |review+
               Flag|                            |




--- Comment #26 from Pavel Feldman <pfeldman at chromium.org>  2012-03-06 02:04:37 PST ---
(From update of attachment 130308)
View in context: https://bugs.webkit.org/attachment.cgi?id=130308&action=review

One small comment, otherwise looks good. Thanks for following up.

> Source/WebCore/inspector/InspectorFrontendClient.h:69
> +    virtual void setDockingUnavailable(bool) { }

I think all the ports that are going to call this methods inherit from InspectorFrontendClientLocal, so you actually don't need it here. It also does not have to be virtual, it is just a helper function.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.