[Webkit-unassigned] [Bug 79875] [BlackBerry] Upstream classes that handle layer tiling

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=79875


Rob Buis <rwlbuis at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #130087|review?                     |review-
               Flag|                            |




--- Comment #11 from Rob Buis <rwlbuis at gmail.com>  2012-03-05 13:12:36 PST ---
(From update of attachment 130087)
View in context: https://bugs.webkit.org/attachment.cgi?id=130087&action=review

Looks good, can be cleaned up some more.

> Source/WebCore/platform/graphics/blackberry/LayerTile.h:25
> +#include "IntRect.h"

Can be just forward references.

> Source/WebCore/platform/graphics/blackberry/LayerTileData.h:26
> +class LayerTileData {

Not sure if this tiny class deserves its own file. Could we put it in LayerTile.h?

> Source/WebCore/platform/graphics/blackberry/LayerTiler.cpp:153
> +        requiredTextureSize = IntSize(m_layer->contents()->width(), m_layer->contents()->height());

m_layer->contents()->size() should give IntSize too.

> Source/WebCore/platform/graphics/blackberry/LayerTiler.cpp:430
> +    }

I'd prefer:
if (result.second) // Successfully added the new job.
    return;

> Source/WebCore/platform/graphics/blackberry/LayerTiler.cpp:527
> +            FloatRect rect(-d, -d, 2*d, 2*d);

Watch spacing 2*d

> Source/WebCore/platform/graphics/blackberry/LayerTiler.h:41
> +class TransformationMatrix;

Not used? Please check all.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.