[Webkit-unassigned] [Bug 79875] [BlackBerry] Upstream classes that handle layer tiling

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=79875





--- Comment #12 from Robin Cao <robin.cao at torchmobile.com.cn>  2012-03-08 04:26:37 PST ---
(In reply to comment #11)
> (From update of attachment 130087 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=130087&action=review
> 
> Looks good, can be cleaned up some more.
> 
> > Source/WebCore/platform/graphics/blackberry/LayerTile.h:25
> > +#include "IntRect.h"
> 
> Can be just forward references.
> 
Fixed.

> > Source/WebCore/platform/graphics/blackberry/LayerTileData.h:26
> > +class LayerTileData {
> 
> Not sure if this tiny class deserves its own file. Could we put it in LayerTile.h?
> 
Fixed

> > Source/WebCore/platform/graphics/blackberry/LayerTiler.cpp:153
> > +        requiredTextureSize = IntSize(m_layer->contents()->width(), m_layer->contents()->height());
> 
> m_layer->contents()->size() should give IntSize too.
> 
Good catch, fixed.

> > Source/WebCore/platform/graphics/blackberry/LayerTiler.cpp:430
> > +    }
> 
> I'd prefer:
> if (result.second) // Successfully added the new job.
>     return;
> 
> > Source/WebCore/platform/graphics/blackberry/LayerTiler.cpp:527
> > +            FloatRect rect(-d, -d, 2*d, 2*d);
> 
> Watch spacing 2*d
> 
Fixed.

> > Source/WebCore/platform/graphics/blackberry/LayerTiler.h:41
> > +class TransformationMatrix;
> 
> Not used? Please check all.

All unnecessary includes and forward declarations are removed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.