[Webkit-unassigned] [Bug 88631] [EFL][WK2] Add ewk_view_touchscreen which has touchscreen behavior.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=88631





--- Comment #16 from EunMi Lee <eunmi15.lee at samsung.com>  2012-06-26 05:41:58 PST ---
(In reply to comment #13)
> (From update of attachment 147743 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=147743&action=review
> 
> Set '-' because above comments.
> 
> > Source/WebKit2/UIProcess/API/efl/ewk_view_touchscreen.cpp:29
> > +using namespace WebCore;
> 
> I wonder why do you add WebCore namespace. I can't find WebCore usage in this file.

Yes right. I will remove it.

> 
> > Source/WebKit2/UIProcess/API/efl/ewk_view_touchscreen.cpp:31
> > +static Ewk_View_Smart_Class g_parentSmartClass = EWK_VIEW_SMART_CLASS_INIT_NULL;
> 
> g_ is GTK port style. Please keep to consistent with WK1 EFL style.

ok, so I will replace g_parentSmartClass to _parentSmartClass.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.