[Webkit-unassigned] [Bug 88631] [EFL][WK2] Add ewk_view_touchscreen which has touchscreen behavior.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=88631





--- Comment #15 from EunMi Lee <eunmi15.lee at samsung.com>  2012-06-26 05:40:13 PST ---
Thanks for your comment.

(In reply to comment #12)
> (From update of attachment 147743 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=147743&action=review
> 
> > Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:103
> > +    static Ewk_View_Type ewkViewType = EWK_VIEW_TYPE_LEGACY;
> 
> Do we really want to default to legacy? LEGACY sounds like "deprecated" and it feels weird that it is the default.
> 
I want to default to legacy because I think webkit2-efl is usually tested on the desktop PC and TOUCHSCREEN mode has to be implemented more.
By the way, does LEGACY sound like "deprecated"?
I considered for name and chose LEGACY like webkit2-qt, but I'm not sure it is good name.
Would you recommend word instead of "legacy"?

> > Source/WebKit2/UIProcess/API/efl/ewk_view.h:139
> > + * is EWK_VIEW_TYPE_LEGACY or legacy behavior if type is EWK_VIEW_TYPE_TOUCHSCREEN.
> 
> Comment is wrong. It reverses legacy and touchscreen.

It's my mistake. I will fix it.
> 
> > Source/WebKit2/UIProcess/API/efl/ewk_view.h:153
> > + *
> 
> We should document which type is the default one.

Yes. I will add.

> 
> > Source/WebKit2/UIProcess/API/efl/ewk_view_private.h:34
> > +const char ewkViewLegacyName[] = "Ewk_View_Legacy";
> 
> Should be static.
> 
> > Source/WebKit2/UIProcess/API/efl/ewk_view_private.h:35
> > +const char ewkViewTouchscreenName[] = "Ewk_View_Touchscreen";
> 
> Ditto.

I will fix it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.